public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xavier Bestel <xavier.bestel@free.fr>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, aia21@cantab.net,
	len.brown@intel.com
Subject: Re: [patch 1/1] consolidate TRUE and FALSE
Date: Thu, 16 Mar 2006 18:09:40 +0100	[thread overview]
Message-ID: <1142528980.22772.36.camel@capoeira> (raw)
In-Reply-To: <20060316160129.GB6407@infradead.org>

On Thu, 2006-03-16 at 17:01, Christoph Hellwig wrote:
> > The patch implements TRUE and FALSE in include/linux/kernel.h and removes all
> > the private versions.
> > 
> > The patch also kills off a few private implementations of NULL.
> 
> NACK.  Just kill them all and use 0/1

I'd say use var == 0 and var != 0 (or var and !var).
While FALSE is obviously 0, TRUE isn't only 1.

	Xav



  parent reply	other threads:[~2006-03-16 17:09 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-16 10:01 [patch 1/1] consolidate TRUE and FALSE akpm
2006-03-16 10:28 ` Anton Altaparmakov
2006-03-16 10:42   ` Andrew Morton
2006-03-16 19:55     ` Nicholas Miell
2006-03-16 19:55     ` Jan Engelhardt
2006-03-16 10:36 ` Arjan van de Ven
2006-03-16 16:01 ` Christoph Hellwig
2006-03-16 16:29   ` Randy.Dunlap
2006-03-16 16:30     ` Christoph Hellwig
2006-03-16 16:36       ` Randy.Dunlap
2006-03-16 16:36         ` Christoph Hellwig
2006-03-16 16:42           ` Anton Altaparmakov
2006-03-16 16:50             ` Al Viro
     [not found]               ` <2c0942db0603160905v26011d8dx1e64967b2eb4deac@mail.gmail.com>
2006-03-16 17:11                 ` Al Viro
2006-03-16 18:50               ` Anton Altaparmakov
2006-03-16 18:53                 ` Anton Altaparmakov
2006-03-16 19:59             ` Jan Engelhardt
2006-03-16 22:35               ` Anton Altaparmakov
2006-03-16 16:42           ` Randy.Dunlap
2006-03-16 16:39       ` Anton Altaparmakov
2006-03-16 17:41       ` Sam Ravnborg
2006-03-16 18:00         ` Al Viro
2006-03-16 18:12           ` Randy.Dunlap
2006-03-16 18:49             ` Al Viro
2006-03-16 18:58               ` Randy.Dunlap
2006-03-16 18:52           ` Sam Ravnborg
2006-03-16 21:17     ` Valdis.Kletnieks
2006-03-16 21:28       ` Joshua Hudson
2006-03-16 23:53     ` David Wagner
2006-03-16 17:09   ` Xavier Bestel [this message]
2006-03-16 16:49 ` Al Viro
2006-03-16 21:26   ` Andrew Morton
2006-03-17 22:43     ` Xavier Bestel
2006-03-17 22:56       ` Andrew Morton
2006-03-18 21:57       ` Jan Engelhardt
2006-03-19 11:41         ` Xavier Bestel
2006-03-16 17:07 ` Greg KH
2006-03-16 17:13   ` Greg KH
2006-03-20 14:46 ` Richard Knutsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1142528980.22772.36.camel@capoeira \
    --to=xavier.bestel@free.fr \
    --cc=aia21@cantab.net \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox