From: Mike Galbraith <efault@gmx.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [2.6.16-rc6 patch] fix interactive task starvation
Date: Sat, 18 Mar 2006 08:48:39 +0100 [thread overview]
Message-ID: <1142668119.7787.7.camel@homer> (raw)
In-Reply-To: <20060317233327.787b4d07.akpm@osdl.org>
On Fri, 2006-03-17 at 23:33 -0800, Andrew Morton wrote:
> > +static int expired_starving(runqueue_t *rq)
>
> I'll make that inline..
>
Oops, I understood you to want that uninlined.
> > +{
> > + int limit;
> > +
> > + /*
> > + * Arrays were recently switched, all is well.
> > + */
> > + if (!rq->expired_timestamp)
> > + return 0;
> > +
> > + limit = STARVATION_LIMIT * rq->nr_running;
>
> In the previous iteration you had, effectively,
>
> if (!limit)
> return 0;
>
> in here. But it's now gone. Deliberate?
Yes. I see no way for it to be zero. I think that was just a leftover.
-Mike
next prev parent reply other threads:[~2006-03-18 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-18 5:08 [2.6.16-rc6 patch] fix interactive task starvation Mike Galbraith
2006-03-18 5:15 ` Andrew Morton
2006-03-18 5:50 ` Mike Galbraith
2006-03-18 6:22 ` Andrew Morton
2006-03-18 7:29 ` Mike Galbraith
2006-03-18 7:33 ` Andrew Morton
2006-03-18 7:48 ` Mike Galbraith [this message]
2006-03-18 7:52 ` Andrew Morton
2006-03-18 8:51 ` Ingo Molnar
2006-03-18 8:05 ` Andrew Morton
2006-03-18 8:15 ` Con Kolivas
2006-03-18 9:43 ` Mike Galbraith
2006-03-18 8:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142668119.7787.7.camel@homer \
--to=efault@gmx.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox