Re: [linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

Greg KH
2006-01-18T20:47:18Z

On Wed, Jan 18, 2006 at 04:34:08PM +0100, Oliver Neukum wrote:
> Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg:
> > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote:
> >
> > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under
> > > a spinlock.
> >
> > Whoops. Good catch. I'll have to analyse the logic with the lists being
> > used here (and probably add a temporary list). Will try to get a new
> > patch until tomorrow.
> >
> > [side note: how about adding might_sleep() to usb_kill_urb? Then I'd at
> > least have noticed this right away]
>
> Good idea.

Done.

thanks,

greg k-h