Re: [PATCH] hci_usb: implement suspend/resume

Marcel Holtmann
2006-01-18T13:14:31Z

Hi Johannes,

> The attached patch implements suspend/resume for the hci_usb bluetooth
> driver by simply killing all outstanding urbs on suspend, and re-issuing
> them on resume.
>
> This allows me to actually use the internal bluetooth "dongle" in my
> powerbook after suspend-to-ram without taking down all userland programs
> (sdpd, ...) and the hci device and reloading the module.

thanks for the patch. Due to the removed owner field it won't apply
cleanly to 2.6.16-rc1, but I can fix this easily by myself.

> +static int hci_usb_resume(struct usb_interface *intf)
> +{
> + struct hci_usb *husb = usb_get_intfdata(intf);
> + int i, err;
> + unsigned long flags;
> + if (!husb || intf == husb->isoc_iface)
> + return 0;
> +
> + for (i = 0; i < 4; i++) {
> + struct _urb_queue *q = &husb->pending_q[i];
> + struct _urb *_urb;
> + spin_lock_irqsave(&q->lock, flags);
> + list_for_each_entry(_urb, &q->head, list) {
> + err = usb_submit_urb(&_urb->urb, GFP_ATOMIC);
> + if (err) break;
> + }
> + spin_unlock_irqrestore(&q->lock, flags);
> + if (err)
> + return -EIO;
> + }
> + return 0;
> +}

What happens if hci_usb_resume() really returns -EIO? Do we have to kill
the URBs again or does the USB subsystems disconnect the device in this
case?

Regards

Marcel