Re: [PATCH 35/46] kbuild: change kbuild to not rely on incorrect GNU make behavior

Sam Ravnborg
2006-03-21T17:54:06Z

On Tue, Mar 21, 2006 at 06:28:20PM +0100, Jan-Benedict Glaw wrote:
> On Tue, 2006-03-21 17:20:57 +0100, Sam Ravnborg <sam@ravnborg.org> wrote:
> > diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> > index c201ef0..d3038b7 100644
> > --- a/scripts/package/Makefile
> > +++ b/scripts/package/Makefile
> > @@ -82,7 +82,7 @@ clean-dirs += $(objtree)/debian/
> >
> > # tarball targets
> > # ---------------------------------------------------------------------------
> > -.PHONY: tar%pkg
> > +PHONY += tar%pkg
> > tar%pkg:
> > $(MAKE) KBUILD_SRC=
> > $(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@
>
> This part is wrong. $(PHONY) isn't subject to pattern matching, so all
> targets that match 'tar%pkg' must be listed here. Fortunately, that's
> only three:
>
> PHONY += tar-pkg targz-pkg tarbz2-pkg

Correct. It is fixed in a later patch were I kill the use of PHONY in
this file.
I got replaced by specifying FORCE as a prerequsite.

Sam