Re: [ck] Re: [PATCH] sched: activate SCHED BATCH expired

Con Kolivas
2006-03-17T13:59:46Z

On Saturday 18 March 2006 00:47, Andreas Mohr wrote:
> Hi,
>
> On Sat, Mar 18, 2006 at 12:36:10AM +1100, Con Kolivas wrote:
> > I'm not attached to the style, just the feature. If you think it's
> > warranted I'll change it.
>
> Seconded.
>
> An even nicer way (this solution seems somewhat asymmetric) than
>
> prio_array_t *target = rq->active;
> if (batch_task(p))
> target = rq->expired;
> enqueue_task(p, target);
>
> may be
>
> prio_array_t *target;
> if (batch_task(p))
> target = rq->expired;
> else
> target = rq->active;
> enqueue_task(p, target);

Well I hadn't quite gone to bed so I tried yours for grins too and
interestingly it produced the identical code to my original version.

> But this discussion is clearly growing out of control now ;)

I prefer a month's worth of this over a single more email about
cd-fscking-record's amazing perfection.

Cheers,
Con