Re: [ck] Re: [PATCH] sched: activate SCHED BATCH expired

Andreas Mohr
2006-03-17T13:47:41Z

Hi,

On Sat, Mar 18, 2006 at 12:36:10AM +1100, Con Kolivas wrote:
> I'm not attached to the style, just the feature. If you think it's warranted
> I'll change it.

Seconded.

An even nicer way (this solution seems somewhat asymmetric) than

prio_array_t *target = rq->active;
if (batch_task(p))
target = rq->expired;
enqueue_task(p, target);

may be

prio_array_t *target;
if (batch_task(p))
target = rq->expired;
else
target = rq->active;
enqueue_task(p, target);

and thus (but this coding style may be considered overloaded):

prio_array_t *target;
target = batch_task(p) ?
rq->expired : rq->active;
enqueue_task(p, target);

But this discussion is clearly growing out of control now ;)

Andreas Mohr