From: Richard Purdie <rpurdie@rpsys.net>
To: Andrew Morton <akpm@osdl.org>
Cc: alan@lxorguk.ukuu.org.uk, bzolnier@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 0/4] LED Updates
Date: Wed, 29 Mar 2006 01:33:05 +0100 [thread overview]
Message-ID: <1143592385.14682.68.camel@localhost.localdomain> (raw)
In-Reply-To: <20060328162300.5bf4f4fc.akpm@osdl.org>
On Tue, 2006-03-28 at 16:23 -0800, Andrew Morton wrote:
> Richard Purdie <rpurdie@rpsys.net> wrote:
> >
> > ...
> >
> > Also add some missing externs.
> >
> > ...
> >
> > /* Registration functions for complex triggers */
> > -int led_trigger_register(struct led_trigger *trigger);
> > -void led_trigger_unregister(struct led_trigger *trigger);
> > +extern int led_trigger_register(struct led_trigger *trigger);
> > +extern void led_trigger_unregister(struct led_trigger *trigger);
>
> Well. The externs weren't "missing". They were "unnecessary". I don't
> know why we do this really - it doesn't communicate any information. Oh
> well.
Half of the leds header had them, half of it didn't. I looked at some
other kernel headers and saw the were present so presumed they were
needed for some reason. Looks like I changed the wrong half... :-/
Richard
prev parent reply other threads:[~2006-03-29 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-29 0:16 [PATCH -mm 0/4] LED Updates Richard Purdie
2006-03-29 0:23 ` Andrew Morton
2006-03-29 0:33 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143592385.14682.68.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox