From: Mike Galbraith <efault@gmx.de>
To: Willy Tarreau <willy@w.ods.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@osdl.org>,
Peter Williams <pwil3058@bigpond.net.au>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Con Kolivas <kernel@kolivas.org>
Subject: Re: [rfc][patch] improved interactive starvation patch against 2.6.16
Date: Thu, 30 Mar 2006 20:23:24 +0200 [thread overview]
Message-ID: <1143743004.7532.33.camel@homer> (raw)
In-Reply-To: <1143728558.7840.11.camel@homer>
On Thu, 2006-03-30 at 16:22 +0200, Mike Galbraith wrote:
> + if (expired_starving(rq)) {
> + int limit = MIN_TIMESLICE + CURRENT_BONUS(p);
> + int runtime = now - p->timestamp;
> +
> + runtime = NS_TO_JIFFIES(runtime);
> + if (runtime >= limit && p->time_slice >= limit) {
> +
> + dequeue_task(p, rq->active);
> + enqueue_task(p, rq->expired);
> + set_tsk_need_resched(p);
> + if (p->prio < rq->best_expired_prio)
> + rq->best_expired_prio = p->prio;
> + }
> + }
This bit isn't cutting it. expired_starving() is routine enough that
short slicing (on this scale at least) is noticed. Don't waste your
time with this one.
-Mike
prev parent reply other threads:[~2006-03-30 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 10:19 [rfc][patch] improved interactive starvation patch against 2.6.16 Mike Galbraith
2006-03-30 11:07 ` Willy Tarreau
2006-03-30 11:55 ` Willy Tarreau
2006-03-30 14:22 ` Mike Galbraith
2006-03-30 14:53 ` Willy Tarreau
2006-03-30 18:23 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143743004.7532.33.camel@homer \
--to=efault@gmx.de \
--cc=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pwil3058@bigpond.net.au \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox