public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Revell <rlrevell@joe-job.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c
Date: Tue, 11 Apr 2006 00:03:56 -0400	[thread overview]
Message-ID: <1144728237.18918.19.camel@mindpipe> (raw)
In-Reply-To: <1144664001.15821.1.camel@alice>

Please send all ALSA bug fixes to alsa-devel (cc'ed)

On Mon, 2006-04-10 at 12:13 +0200, Eric Sesterhenn wrote:
> hi,
> 
> since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST],
> it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
> 
> --- linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c.orig	2006-04-10 12:10:22.000000000 +0200
> +++ linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c	2006-04-10 12:10:41.000000000 +0200
> @@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
>  	int i;
>  	int err, nr_capt;
>  
> -	if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
> +	if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
>  		return -ENODEV;
>  
>  	/* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the 
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


      reply	other threads:[~2006-04-11  4:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-10 10:13 [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c Eric Sesterhenn
2006-04-11  4:03 ` Lee Revell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1144728237.18918.19.camel@mindpipe \
    --to=rlrevell@joe-job.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snakebyte@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox