From: Dustin Kirkland <dustin.kirkland@us.ibm.com>
To: Avi Kivity <avi@argo.co.il>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Kylene Jo Hall <kjhall@us.ibm.com>,
kbuild-devel@lists.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make: add modules_update target
Date: Fri, 14 Apr 2006 19:33:37 -0500 [thread overview]
Message-ID: <1145061217.4001.24.camel@localhost.localdomain> (raw)
In-Reply-To: <443FF1D9.4060904@argo.co.il>
On Fri, 2006-04-14 at 22:02 +0300, Avi Kivity wrote:
> Use rsync only if it is available:
>
> rsync-available := $(shell rsync --version > /dev/null 2>&1 && echo y)
> copy := $(if $(rsync-available), rsync --delete, cp)
>
> modules_install:
> [...]
> $(copy) source target
Actually, rsync --delete is not a viable option either. If you first
build a kernel with a particular item built as a module, and then
afterward rebuild with the same item as built-in (or not at all),
the .ko file remains in your kernel build tree (ie, it won't be deleted
on the source such that the --delete would have your desired effect).
Furthermore, rsync's performance is considerably worse in my testing
than "cp -u", almost back to the original performance of the "rm -rf, cp
all" of the original modules_install. (Note that I tested, rsync's
default, checksum, mod-times, and size-only.)
:-Dustin
next prev parent reply other threads:[~2006-04-15 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 15:06 [PATCH] make: add modules_update target Kylene Jo Hall
2006-04-14 17:02 ` Theodore Ts'o
2006-04-14 18:00 ` Avi Kivity
2006-04-14 18:29 ` Dustin Kirkland
2006-04-14 19:02 ` Avi Kivity
2006-04-15 0:33 ` Dustin Kirkland [this message]
2006-04-15 0:33 ` Dustin Kirkland
2006-04-15 8:40 ` Sam Ravnborg
2006-04-15 15:02 ` Theodore Ts'o
2006-04-16 18:24 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145061217.4001.24.camel@localhost.localdomain \
--to=dustin.kirkland@us.ibm.com \
--cc=avi@argo.co.il \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox