public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dustin Kirkland <dustin.kirkland@us.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Kylene Jo Hall <kjhall@us.ibm.com>,
	kbuild-devel@lists.sourceforge.net,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make: add modules_update target
Date: Fri, 14 Apr 2006 19:33:39 -0500	[thread overview]
Message-ID: <1145061219.4001.25.camel@localhost.localdomain> (raw)
In-Reply-To: <20060414170222.GA19172@thunk.org>

On Fri, 2006-04-14 at 13:02 -0400, Theodore Ts'o wrote: 
> This works as long as the .config hasn't been changed so that some
> configuration options haven't been changed so that a driver which had
> been previously built as a module is now built into the kernel.  In
> that case, you really want to make sure the no-longer applicable .ko
> file has been removed from the system.  If the developer knows that to
> be true, they can use your proposed modules_update without any problems.
> 
> As a suggestion, something that might be worth trying would be to
> change to modules_install so that it uses cp -u, but also so that it
> tries to delete all files that could have previously installed as
> modules (by using the obj-y list).  This should hopefully speed up
> modules_install, and make it do the right thing all the time.

Ted-

So I found the obj-y list a little tough to work with, as the objects
listed there do not contain fully qualified paths describing their
locations.

Here's another approach...

What you would think of some logic such that 

        if .config file has changed since last modules_install
                call normal brute force modules_install target
        else
                call this new, more efficient modules_update target
        
I was looking through the top level Makefile for a flag or some such
that would determine if a .config file has changed since last build, to
no avail.

It would be pretty easy to maintain an md5sum/sha1sum signature of
the .config used to perform a modules install/update (.config.md5), and
compare the signature of the current .conf with the previous to
determine change.

It looks like it may not be easy to drop in modules_update as a more
efficient alternative to modules_install, but note that is not the patch
that Kylie submitted...  

I suggest that it might be sufficient to document modules_update as a
handy, more efficient development build target when someone is working
on one particular module-built aspect of the kernel.  And clearly note
that to perform a full, clean /lib/modules/`uname -r`/kernel
synchronization with a given build tree, the more thorough
modules_install target is preferred.

Thoughts?

:-Dustin


  parent reply	other threads:[~2006-04-15  0:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-14 15:06 [PATCH] make: add modules_update target Kylene Jo Hall
2006-04-14 17:02 ` Theodore Ts'o
2006-04-14 18:00   ` Avi Kivity
2006-04-14 18:29     ` Dustin Kirkland
2006-04-14 19:02       ` Avi Kivity
2006-04-15  0:33         ` Dustin Kirkland
2006-04-15  0:33   ` Dustin Kirkland [this message]
2006-04-15  8:40     ` Sam Ravnborg
2006-04-15 15:02       ` Theodore Ts'o
2006-04-16 18:24         ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145061219.4001.25.camel@localhost.localdomain \
    --to=dustin.kirkland@us.ibm.com \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=kjhall@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox