From: Adrian McMenamin <adrian@mcmen.demon.co.uk>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Alsa-devel <alsa-devel@lists.sourceforge.net>,
linux-sh <linuxsh-dev@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast
Date: Mon, 17 Apr 2006 21:00:36 +0100 [thread overview]
Message-ID: <1145304037.9244.27.camel@localhost.localdomain> (raw)
In-Reply-To: <20060417012913.GA16821@linux-sh.org>
>
> > + /* AICA has no capture ability */
> > + if ((err =
> > + snd_pcm_new(dreamcastcard->card, "AICA PCM", pcm_index, 1, 0,
> > + &pcm)) < 0)
> > + return err;
>
> Weird notation, linux kernel style would be:
>
> err = snc_pcm_new(...);
> if (unlikely(err < 0))
> return err;
>
> please refactor accordingly.
>
Actually this sort of formulation is common in the kernel as any grep
will show. In fact I copied it directly from the guide to writing ALSA
drivers:
http://www.alsa-project.org/~iwai/writing-an-alsa-driver/x447.htm
But I am happy to change it.
next prev parent reply other threads:[~2006-04-17 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1145232784.12804.2.camel@localhost.localdomain>
2006-04-17 1:29 ` [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast Paul Mundt
2006-04-17 9:44 ` [Alsa-devel] " Adrian McMenamin
2006-04-17 20:00 ` Adrian McMenamin [this message]
2006-04-17 21:47 ` Lee Revell
2006-04-17 22:05 ` Christoph Hellwig
2006-04-17 22:15 ` Lee Revell
2006-04-18 10:17 ` Takashi Iwai
2006-04-18 11:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145304037.9244.27.camel@localhost.localdomain \
--to=adrian@mcmen.demon.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxsh-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox