public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Hua Zhong <hzhong@gmail.com>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
	akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] Rename "swapper" to "idle"
Date: Thu, 20 Apr 2006 20:17:35 -0400	[thread overview]
Message-ID: <1145578655.671.39.camel@localhost.localdomain> (raw)
In-Reply-To: <4448161D.9010109@gmail.com>

On Thu, 2006-04-20 at 16:15 -0700, Hua Zhong wrote:
> This patch renames the "swapper" process (pid 0) to a more appropriate name "idle". The name "swapper" is not obviously meaningful and confuses a lot of people (e.g., when seen in oops report).
> 
> Patch not tested, but I guess it works. :-)

Usually a patch not tested will never be accepted no matter how trivial
it is, unless you had to modify a driver to match a new syntax or
something and you don't have the device.  Did you at least compile it?

> 
> Signed-off-by: Hua Zhong <hzhong@gmail.com>
> 
> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
> index 41ecbb8..5e3ca4f 100644
> --- a/include/linux/init_task.h
> +++ b/include/linux/init_task.h
> @@ -108,7 +108,7 @@ #define INIT_TASK(tsk)      \
>         .cap_permitted  = CAP_FULL_SET,                                 \
>         .keep_capabilities = 0,                                         \
>         .user           = INIT_USER,                                    \
> -       .comm           = "swapper",                                    \
> +       .comm           = "idle",                                       \
>         .thread         = INIT_THREAD,                                  \
>         .fs             = &init_fs,                                     \
>         .files          = &init_files,                                  \
> -

Yes, swapper is because of historical reasons.  In most text books for
Unix, the initial process on boot up is called "swapper".  Probably
because those early Unix systems had this process handle the swapping
(as kswapd does today).

By doing this, it will probably make Linux out of sync with all the text
books on Unix, so it really is Linus' call.

-- Steve



  reply	other threads:[~2006-04-21  0:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 23:15 [PATCH] Rename "swapper" to "idle" Hua Zhong
2006-04-21  0:17 ` Steven Rostedt [this message]
2006-04-21  0:35 ` Bernd Eckenfels
2006-04-21  4:18   ` Joshua Hudson
2006-04-21  5:19     ` Hua Zhong
2006-04-21 14:40       ` Mikado
2006-04-21 14:56         ` Michael Buesch
2006-04-21 15:08           ` Jan Engelhardt
2006-04-21 17:05             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145578655.671.39.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=akpm@osdl.org \
    --cc=hzhong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox