public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Sam Ravnborg <sam@mars.ravnborg.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Removing .tmp_versions considered harmful
Date: Fri, 21 Apr 2006 00:22:22 -0400	[thread overview]
Message-ID: <1145593342.2904.30.camel@dv> (raw)

Hello!

A patch applied shortly after Linux 2.6.16
(fb3cbd2e575f9ac0700bfa1e7cb9f4119fbd0abd in git) causes
the .tmp_versions directory to be removed every time make is run to
build external modules.

This is bad for two reasons.

1) When "make install" is run as root, .tmp_versions is re-created and
becomes owned by root.  Subsequent "make" by user fails
because .tmp_versions cannot be removed.

2) The projects where modules are build in more than one directory (such
as MadWifi) are now compiled with spurious warnings about unresolved
symbols.  This happens because every module is compiled individually,
and the *.mod files for one module are removed before the other is
compiled.

In both cases, I cannot think of any sane workarounds.  For the first
problem, MODVERDIR could be set to different values for different
usernames.  For the second problem, I considered clever ways to sabotage
some targets based on the target name, something like:

divert_crmodverdir = some_other_dir
MODVERDIR=$(SYMBOLSDIR)'$$(divert_$$@)'

When I looked on this the next day I realized that it's ugly as hell.
Why should I invent workarounds for what should be a standard situation?

Since I don't see any better approach, I'm asking the commit
fb3cbd2e575f9ac0700bfa1e7cb9f4119fbd0abd to be reverted for Linux
2.6.17.  The problem it solves (stale *.mod files) is not nearly as big
as the problems it creates.

Note that the removal on *.mod files only would not address the MadWifi
problem.

-- 
Regards,
Pavel Roskin


             reply	other threads:[~2006-04-21  4:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-21  4:22 Pavel Roskin [this message]
2006-04-21  7:32 ` Removing .tmp_versions considered harmful Sam Ravnborg
2006-04-21 11:55   ` Pavel Roskin
2006-04-24 19:55   ` Pavel Roskin
2006-04-24 19:58     ` Arjan van de Ven
2006-04-24 20:19       ` Pavel Roskin
2006-04-30 21:47     ` Sam Ravnborg
2006-05-01  0:59       ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145593342.2904.30.camel@dv \
    --to=proski@gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@mars.ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox