public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Michael Holzheu <HOLZHEU@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, mschwid2@de.ibm.com, penberg@gmail.com
Subject: Re: [PATCH/RFC] s390: Hypervisor File System
Date: Fri, 21 Apr 2006 18:41:40 +0300	[thread overview]
Message-ID: <1145634100.13191.12.camel@localhost> (raw)
In-Reply-To: <OFB753A28F.DD67C970-ON42257157.0051D51C-42257157.0052637A@de.ibm.com>

On Fri, 2006-04-21 at 16:59 +0200, Michael Holzheu wrote:
> > > +struct x_info_blk_hdr {
> > > +   __u8  npar;
> > > +   __u8  flags;
> > > +   __u16 tslice;
> > > +   __u16 phys_cpus;
> > > +   __u16 this_part;
> > > +   __u64 curtod1;
> > > +   __u64 curtod2;
> > > +   char reserved[40];
> > > +} __attribute__ ((packed));
> >
> > Couldn't you use endianess annotated types for these?
> 
> What are "endianess annotated types" ?

For example, __le16 and __be16 (search for __bitwise in
<linux/types.h>). You can use sparse to check for endianess erros in
your code if you us them.

				Pekka


  reply	other threads:[~2006-04-21 15:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-21 11:35 [PATCH/RFC] s390: Hypervisor File System Michael Holzheu
2006-04-21 11:53 ` Pekka Enberg
2006-04-21 13:56   ` Michael Holzheu
2006-04-21 14:55     ` Arnd Bergmann
2006-04-21 15:31       ` Michael Holzheu
2006-04-21 13:32 ` Pekka Enberg
2006-04-21 14:08   ` Michael Holzheu
2006-04-21 15:38     ` Pekka Enberg
2006-04-21 16:40       ` Martin Schwidefsky
2006-04-25 14:04         ` Pekka Enberg
2006-04-21 14:42 ` Pekka Enberg
2006-04-21 14:59   ` Michael Holzheu
2006-04-21 15:41     ` Pekka Enberg [this message]
2006-04-21 15:18   ` Jörn Engel
2006-04-21 15:36     ` Michael Holzheu
2006-04-21 15:46       ` Jörn Engel
2006-04-21 22:30   ` Ingo Oeser
2006-04-24 17:17     ` Michael Holzheu
2006-04-24 19:57       ` Ingo Oeser
2006-04-25  6:27       ` Pekka Enberg
2006-04-24 17:19   ` Michael Holzheu
  -- strict thread matches above, loose matches on Subject: below --
2006-04-24 17:19 Michael Holzheu
2006-04-25  6:58 ` Pekka Enberg
2006-04-25  7:32   ` Pekka Enberg
2006-04-25  7:47     ` Andrew Morton
2006-04-25  8:01       ` Pekka Enberg
2006-04-25  8:52     ` Jörn Engel
2006-04-25  9:00       ` Pekka Enberg
2006-04-25 12:22     ` Michael Holzheu
2006-04-25 14:33 ` Pekka Enberg
2006-04-25 14:45   ` Jörn Engel
2006-04-26  9:30   ` Michael Holzheu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145634100.13191.12.camel@localhost \
    --to=penberg@cs.helsinki.fi \
    --cc=HOLZHEU@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschwid2@de.ibm.com \
    --cc=penberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox