The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "mao, bibo" <bibo.mao@intel.com>
To: Andrew Morton <akpm@osdl.org>,
	Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp>,
	Jim Keniston <jkenisto@us.ibm.com>,
	"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	prasanna <prasanna@in.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"systemtap@sources.redhat.com" <systemtap@sources.redhat.com>
Subject: [PATCH] kprobe cleanup for VM_MASK judgement
Date: Wed, 26 Apr 2006 17:56:26 +0800	[thread overview]
Message-ID: <1146045386.29367.8.camel@maobb.site> (raw)

Hi,
When trap happens in user space, kprobe_exceptions_notify() funtion will skip it. 
This patch deletes some unnecessary code for VM_MASK judgement in eflags.

Signed-off-by: bibo, mao <bibo.mao@intel.com>
 
Thanks
bibo,mao

diff -Nruap 2.6.17-rc1-mm3.org/arch/i386/kernel/kprobes.c 2.6.17-rc1-mm3.new/arch/i386/kernel/kprobes.c
--- 2.6.17-rc1-mm3.org/arch/i386/kernel/kprobes.c	2006-04-26 15:52:24.000000000 +0800
+++ 2.6.17-rc1-mm3.new/arch/i386/kernel/kprobes.c	2006-04-26 16:25:38.000000000 +0800
@@ -242,10 +242,6 @@ static int __kprobes kprobe_handler(stru
 			kcb->kprobe_status = KPROBE_REENTER;
 			return 1;
 		} else {
-			if (regs->eflags & VM_MASK) {
-			/* We are in virtual-8086 mode. Return 0 */
-				goto no_kprobe;
-			}
 			if (*addr != BREAKPOINT_INSTRUCTION) {
 			/* The breakpoint instruction was removed by
 			 * another cpu right after we hit, no further
@@ -265,11 +261,6 @@ static int __kprobes kprobe_handler(stru
 
 	p = get_kprobe(addr);
 	if (!p) {
-		if (regs->eflags & VM_MASK) {
-			/* We are in virtual-8086 mode. Return 0 */
-			goto no_kprobe;
-		}
-
 		if (*addr != BREAKPOINT_INSTRUCTION) {
 			/*
 			 * The breakpoint instruction was removed right

             reply	other threads:[~2006-04-26  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26  9:56 mao, bibo [this message]
2006-04-26 16:43 ` [PATCH] kprobe cleanup for VM_MASK judgement Keshavamurthy Anil S
2006-04-26 17:57 ` Prasanna S Panchamukhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1146045386.29367.8.camel@maobb.site \
    --to=bibo.mao@intel.com \
    --cc=akpm@osdl.org \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=hiramatu@sdl.hitachi.co.jp \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasanna@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox