From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757794AbbDWNpn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Apr 2015 09:45:43 -0400
Received: from mail.efficios.com ([78.47.125.74]:38955 "EHLO mail.efficios.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752212AbbDWNpm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Apr 2015 09:45:42 -0400
Date: Thu, 23 Apr 2015 13:45:40 +0000 (UTC)
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
        Pranith Kumar <bobby.prani@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Nicholas Miell <nmiell@comcast.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
        Lai Jiangshan <laijs@cn.fujitsu.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        David Howells <dhowells@redhat.com>,
        Michael Kerrisk <mtk.manpages@gmail.com>
Message-ID: <1146370149.34873.1429796740391.JavaMail.zimbra@efficios.com>
In-Reply-To: <20150422224850.76064d98@grimm.local.home>
References: <1429283202-6245-1-git-send-email-mathieu.desnoyers@efficios.com> <CAJhHMCDRvv5PASOeX5oteOGKacUN3RiHN+whLcZk+xhGj19-4Q@mail.gmail.com> <1526056761.34535.1429735242508.JavaMail.zimbra@efficios.com> <CAJhHMCD0Dxbsf5ZUaFbt8GvCMJDTj5d8m7tUx7GAd1=t+zED8A@mail.gmail.com> <20150422174051.5c868437@urahara> <20150422224850.76064d98@grimm.local.home>
Subject: Re: [PATCH v16] sys_membarrier(): system-wide memory barrier
 (generic, x86)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [192.222.194.238]
X-Mailer: Zimbra 8.0.7_GA_6021 (ZimbraWebClient - FF37 (Linux)/8.0.7_GA_6021)
Thread-Topic: sys_membarrier(): system-wide memory barrier (generic, x86)
Thread-Index: gNXAVkCTd9nMl22LKu45T1uPVTS9Zw==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

----- Original Message -----
> On Wed, 22 Apr 2015 17:40:51 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> > The syscall should just return 0.
> > Let the application not worry about how many CPU's are present
> 
> +1

This is indeed how I implemented it initially. The nice thing
about this approach is that if the application don't care much
about the overhead of calling sys_membarrier on !SMP, returning
0 tells the application that sys_membarrier is indeed supported,
and that the application don't need to issue memory barriers on
the other target threads (compiler barrier is then sufficient),
which is correct.

I'll update the patch accordingly.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com