From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, Seokmann.Ju@lsil.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] megaraid gcc 4.1 warning fix
Date: Wed, 10 May 2006 11:39:18 +0100 [thread overview]
Message-ID: <1147257558.17886.8.camel@localhost.localdomain> (raw)
In-Reply-To: <200605100256.k4A2u3lB031731@dwalker1.mvista.com>
On Maw, 2006-05-09 at 19:56 -0700, Daniel Walker wrote:
> Fixes the following warning,
>
> drivers/scsi/megaraid.c: In function ‘issue_scb’:
> drivers/scsi/megaraid.c:1153: warning: passing argument 2 of ‘writel’ makes pointer from integer without a cast
And adds an exploitable memory leak. Please don't fix "bugs" blindly but
check that the error path still releases all the relevant resources.
In this case its probably sufficient just to set rval and fal through,
but each one needs to be reviewed properly.
Alan
next prev parent reply other threads:[~2006-05-10 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:56 [PATCH -mm] megaraid gcc 4.1 warning fix Daniel Walker
2006-05-10 6:15 ` Pekka Enberg
2006-05-10 10:39 ` Alan Cox [this message]
2006-05-10 14:13 ` Daniel Walker
2006-05-10 14:21 ` Daniel Walker
2006-05-10 15:08 ` Alan Cox
2006-05-10 15:03 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147257558.17886.8.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Seokmann.Ju@lsil.com \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox