From: Dave Hansen <haveblue@us.ibm.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm@kvack.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Hugetlb demotion for x86
Date: Wed, 10 May 2006 12:46:40 -0700 [thread overview]
Message-ID: <1147290400.17933.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1147287400.24029.81.camel@localhost.localdomain>
On Wed, 2006-05-10 at 13:56 -0500, Adam Litke wrote:
> +install_demotion_ptes(struct mm_struct *mm, struct page *page,
> + pgprot_t prot, unsigned long address)
> +{
> + pgd_t *pgd;
> + pud_t *pud;
> + pmd_t *pmd;
> + pte_t entry, *ptep;
> + int pfn, i;
> +
> + pgd = pgd_offset(mm, address);
> + pud = pud_alloc(mm, pgd, address);
> + if (!pud)
> + return -ENOMEM;
> + pmd = pmd_alloc(mm, pud, address);
> + if (!pmd)
> + return -ENOMEM;
That looks to be a pretty direct copy of what is already in
__handle_mm_fault(). Can they be consolidated?
-- Dave
next prev parent reply other threads:[~2006-05-10 19:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 18:56 [RFC] Hugetlb demotion for x86 Adam Litke
2006-05-10 19:46 ` Dave Hansen [this message]
2006-05-10 19:49 ` Dave Hansen
2006-05-10 20:05 ` Christoph Hellwig
2006-05-10 20:32 ` Adam Litke
2006-05-10 20:49 ` Christoph Hellwig
2006-05-10 21:45 ` Adam Litke
2006-05-11 15:15 ` Hugh Dickins
2006-05-11 15:33 ` Alan Cox
2006-05-11 15:59 ` Adam Litke
2006-05-10 21:38 ` Andi Kleen
2006-05-10 23:42 ` Christoph Lameter
2006-05-11 16:10 ` Adam Litke
2006-05-15 14:20 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147290400.17933.3.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=agl@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox