From: Ram Pai <linuxram@us.ibm.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL
Date: Mon, 15 May 2006 12:14:38 -0700 [thread overview]
Message-ID: <1147720478.4884.74.camel@localhost> (raw)
In-Reply-To: <200605151900.k4FJ0ktD006410@turing-police.cc.vt.edu>
On Mon, 2006-05-15 at 15:00 -0400, Valdis.Kletnieks@vt.edu wrote:
> It looks like a buggy comparison down in the guts of
> kbuild-export-type-enhancement-to-modpostc.patch - it's doing
> something really odd when it hits a EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> ---
> Proposed fix (with an added debugging warning Just In Case:
>
> --- linux-2.6.17-rc4-mm1/scripts/mod/modpost.c.whatdied 2006-05-15 13:50:13.000000000 -0400
> +++ linux-2.6.17-rc4-mm1/scripts/mod/modpost.c 2006-05-15 14:52:13.000000000 -0400
> @@ -1194,12 +1194,14 @@
> *d != '\0')
> goto fail;
>
> - if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
> + if ((strcmp(export, "EXPORT_SYMBOL_GPL") == 0))
Yes my mistake. Error while merging in Andreas's fix. :(
Andrew, can apply this patch on top of the other patches?
RP
> export_type = 1;
> else if(strcmp(export, "EXPORT_SYMBOL") == 0)
> export_type = 0;
> - else
> + else {
> + warn("Odd symbol export=%s symname=%s modname=%s\n",export,symname,modname);
> goto fail;
> + }
>
> if (!(mod = find_module(modname))) {
> if (is_vmlinux(modname)) {
>
>
prev parent reply other threads:[~2006-05-15 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 19:00 [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL Valdis.Kletnieks
2006-05-15 19:14 ` Ram Pai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147720478.4884.74.camel@localhost \
--to=linuxram@us.ibm.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox