* [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL
@ 2006-05-15 19:00 Valdis.Kletnieks
2006-05-15 19:14 ` Ram Pai
0 siblings, 1 reply; 2+ messages in thread
From: Valdis.Kletnieks @ 2006-05-15 19:00 UTC (permalink / raw)
To: Andrew Morton, Ram Pai; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
It looks like a buggy comparison down in the guts of
kbuild-export-type-enhancement-to-modpostc.patch - it's doing
something really odd when it hits a EXPORT_SYMBOL_GPL.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
Proposed fix (with an added debugging warning Just In Case:
--- linux-2.6.17-rc4-mm1/scripts/mod/modpost.c.whatdied 2006-05-15 13:50:13.000000000 -0400
+++ linux-2.6.17-rc4-mm1/scripts/mod/modpost.c 2006-05-15 14:52:13.000000000 -0400
@@ -1194,12 +1194,14 @@
*d != '\0')
goto fail;
- if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
+ if ((strcmp(export, "EXPORT_SYMBOL_GPL") == 0))
export_type = 1;
else if(strcmp(export, "EXPORT_SYMBOL") == 0)
export_type = 0;
- else
+ else {
+ warn("Odd symbol export=%s symname=%s modname=%s\n",export,symname,modname);
goto fail;
+ }
if (!(mod = find_module(modname))) {
if (is_vmlinux(modname)) {
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL
2006-05-15 19:00 [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL Valdis.Kletnieks
@ 2006-05-15 19:14 ` Ram Pai
0 siblings, 0 replies; 2+ messages in thread
From: Ram Pai @ 2006-05-15 19:14 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: Andrew Morton, linux-kernel
On Mon, 2006-05-15 at 15:00 -0400, Valdis.Kletnieks@vt.edu wrote:
> It looks like a buggy comparison down in the guts of
> kbuild-export-type-enhancement-to-modpostc.patch - it's doing
> something really odd when it hits a EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> ---
> Proposed fix (with an added debugging warning Just In Case:
>
> --- linux-2.6.17-rc4-mm1/scripts/mod/modpost.c.whatdied 2006-05-15 13:50:13.000000000 -0400
> +++ linux-2.6.17-rc4-mm1/scripts/mod/modpost.c 2006-05-15 14:52:13.000000000 -0400
> @@ -1194,12 +1194,14 @@
> *d != '\0')
> goto fail;
>
> - if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
> + if ((strcmp(export, "EXPORT_SYMBOL_GPL") == 0))
Yes my mistake. Error while merging in Andreas's fix. :(
Andrew, can apply this patch on top of the other patches?
RP
> export_type = 1;
> else if(strcmp(export, "EXPORT_SYMBOL") == 0)
> export_type = 0;
> - else
> + else {
> + warn("Odd symbol export=%s symname=%s modname=%s\n",export,symname,modname);
> goto fail;
> + }
>
> if (!(mod = find_module(modname))) {
> if (is_vmlinux(modname)) {
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-15 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-15 19:00 [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL Valdis.Kletnieks
2006-05-15 19:14 ` Ram Pai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox