From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Dave Jones <davej@redhat.com>, akpm@osdl.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390: next_timer_interrupt overflow in stop_hz_timer
Date: Tue, 23 May 2006 09:22:42 +0200 [thread overview]
Message-ID: <1148368962.5402.4.camel@localhost> (raw)
In-Reply-To: <20060522201428.GA10346@redhat.com>
On Mon, 2006-05-22 at 16:14 -0400, Dave Jones wrote:
> arch/s390/kernel/time.c: In function 'stop_hz_timer':
> arch/s390/kernel/time.c:275: error: expected ')' before 'next'
> arch/s390/kernel/time.c:275: error: expected ')' before 'jiffies'
Argh,
I really have to stop doing things in a hurry. This result in stupid
things like missing parentheses for a type cast.
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
--
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
[patch] s390: fix typo in stop_hz_timer.
Add missing parentheses for type cast to u64.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
arch/s390/kernel/time.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/arch/s390/kernel/time.c linux-2.6-patched/arch/s390/kernel/time.c
--- linux-2.6/arch/s390/kernel/time.c 2006-05-23 09:10:41.000000000 +0200
+++ linux-2.6-patched/arch/s390/kernel/time.c 2006-05-23 09:04:47.000000000 +0200
@@ -273,7 +273,7 @@ static inline void stop_hz_timer(void)
next = next_timer_interrupt();
do {
seq = read_seqbegin_irqsave(&xtime_lock, flags);
- timer = (__u64 next) - (__u64 jiffies) + jiffies_64;
+ timer = ((__u64) next) - ((__u64) jiffies) + jiffies_64;
} while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
todval = -1ULL;
/* Be careful about overflows. */
prev parent reply other threads:[~2006-05-23 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200605212100.k4LL0pCX012928@hera.kernel.org>
2006-05-22 20:14 ` [PATCH] s390: next_timer_interrupt overflow in stop_hz_timer Dave Jones
2006-05-23 7:22 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148368962.5402.4.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox