Re: 2.6.17-rc5-mm1

Ingo Molnar
2006-05-30T23:04:55Z

* Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> I'll try to reproduce that bug now... but here is new one :)
>
> BUG: key f7155db0 not in .data!
> ( modprobe-485 |#0): new 15286092 us user-latency.
> stopped custom tracer.
> BUG: warning at /usr/src/linux-mm/kernel/lockdep.c:1985/lockdep_init_map()

Arjan's sound patch is wrong: the key must not be in a dynamic variable!

Could you try the patch below? This uses the ID string as the key. (the
ID string seems to be based on static kernel strings most of the time,
so this might as well work)

Ingo

Index: linux/sound/core/seq/seq_device.c
===================================================================
--- linux.orig/sound/core/seq/seq_device.c
+++ linux/sound/core/seq/seq_device.c
@@ -382,7 +382,7 @@ static struct ops_list * create_driver(c

/* set up driver entry */
strlcpy(ops->id, id, sizeof(ops->id));
- mutex_init_key(&ops->reg_mutex, id, &ops->reg_mutex_key);
+ mutex_init_key(&ops->reg_mutex, id, (struct lockdep_type_key)id);
ops->driver = DRIVER_EMPTY;
INIT_LIST_HEAD(&ops->dev_list);
/* lock this instance */