public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adam Belay <abelay@novell.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 9/9] PCI PM: generic suspend/resume fixes
Date: Mon, 05 Jun 2006 11:21:31 +0100	[thread overview]
Message-ID: <1149502891.30554.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1149497178.7831.163.camel@localhost.localdomain>

Ar Llu, 2006-06-05 am 04:46 -0400, ysgrifennodd Adam Belay:
> + * Default suspend method for devices that have no driver provided suspend,
> + * or not even a driver at all.
> + */
> +static void pci_default_suspend(struct pci_dev *pci_dev)
> +{
> +	pci_save_state(pci_dev);
> +	pci_disable_device(pci_dev);
> +}

How much testing has this had ? When people starting doing
disable_device on arbitary hardware various platforms broke horribly
as a result.



  reply	other threads:[~2006-06-05 10:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05  8:46 [PATCH 9/9] PCI PM: generic suspend/resume fixes Adam Belay
2006-06-05 10:21 ` Alan Cox [this message]
2006-06-05 17:48   ` Adam Belay
2006-06-05 18:45     ` Alan Cox
2006-06-06  0:33     ` Benjamin Herrenschmidt
2006-06-07  3:13       ` Adam Belay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149502891.30554.1.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=abelay@novell.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox