public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch] Fix typo in drivers/isdn/hisax/q931.c
@ 2006-06-05 19:06 Eric Sesterhenn
  0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-06-05 19:06 UTC (permalink / raw)
  To: linux-kernel; +Cc: isdn4linux

hi,

this fixes coverity bug #517. 
Since IESIZE is greater than IESIZE_NI1 we might run past the end
of ielist_ni1. This fixes it by using the proper IESIZE_NI1 define.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> 

--- linux-2.6.17-rc5/drivers/isdn/hisax/q931.c.orig	2006-06-05 20:57:11.000000000 +0200
+++ linux-2.6.17-rc5/drivers/isdn/hisax/q931.c	2006-06-05 20:57:50.000000000 +0200
@@ -1402,12 +1402,12 @@ dlogframe(struct IsdnCardState *cs, stru
 			}
 			/* No, locate it in the table */
 			if (cset == 0) {
-				for (i = 0; i < IESIZE; i++)
+				for (i = 0; i < IESIZE_NI1; i++)
 					if (*buf == ielist_ni1[i].nr)
 						break;
 
 				/* When not found, give appropriate msg */
-				if (i != IESIZE) {
+				if (i != IESIZE_NI1) {
 					dp += sprintf(dp, "  %s\n", ielist_ni1[i].descr);
 					dp += ielist_ni1[i].f(dp, buf);
 				} else



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-06-05 19:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-05 19:06 [Patch] Fix typo in drivers/isdn/hisax/q931.c Eric Sesterhenn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox