From: Paul Fulghum <paulkf@microgate.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
davej@redhat.com, akpm@osdl.org, linux-kernel@vger.kernel.org,
zippel@linux-m68k.org
Subject: Re: [PATCH] fix missing hdlc symbols for synclink drivers
Date: Tue, 06 Jun 2006 20:09:05 -0500 [thread overview]
Message-ID: <1149642545.2633.49.camel@localhost.localdomain> (raw)
In-Reply-To: <m364jdbxu8.fsf@defiant.localdomain>
On Wed, 2006-06-07 at 02:42 +0200, Krzysztof Halasa wrote:
> I don't know what special flexibility are you thinking about.
> DEPENDing on a symbol is as flexible and causes no such problems.
> The user just needs to enable (in this case) WAN and HDLC
> manually ((s)he has to select HDLC_* manually anyway). It could
> even make SYNCLINK_*_HDLC unneeded, the added functionality could
> (optionally) be selected automagically.
That is close to the way it was working, but it
had build errors with synclink=y and hdlc=m which
is what started all of these patches.
I guess I could add an extra check for that broken config
case in all the individual source files using conditional compilation
and disable synclink HDLC support altogether if such
a broken selection of options occurs (through
a random config generation). Still messy, but
since there seems to be a consensus that using the 'select'
facility of kbuild is forbidden, that may be the more
politically palatable way to go.
--
Paul
next prev parent reply other threads:[~2006-06-07 1:09 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 6:20 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 9:38 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-04 9:49 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 10:08 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-04 10:41 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 20:38 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-04 21:49 ` [patch, -rc5-mm3] lock validator: early_init_irq_lock_type() build fix Ingo Molnar
[not found] ` <6bffcb0e0606040407u4f56f7fdyf5ec479314afc082@mail.gmail.com>
2006-06-04 21:38 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 22:35 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-05 8:30 ` [patch, -rc5-mm3] fix IDE deadlock in error reporting code Ingo Molnar
2006-06-05 8:35 ` Ingo Molnar
2006-06-05 11:33 ` Michal Piotrowski
2006-06-05 12:24 ` Ingo Molnar
2006-06-05 12:35 ` Michal Piotrowski
2006-06-04 18:20 ` 2.6.17-rc5-mm3 Rafael J. Wysocki
2006-06-04 23:01 ` [trivial patch, rc5-mm3] fix typo in acpi pm info message Frederik Deweerdt
2006-06-04 23:15 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-04 23:42 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 6:02 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-05 8:04 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-04 23:28 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-05 0:06 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-05 0:25 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 0:45 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 9:12 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 17:56 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 18:54 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-06 9:43 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-06 10:57 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 19:48 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:06 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 20:09 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:44 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:53 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 21:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 21:03 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-06 10:15 ` 2.6.17-rc5-mm3 Takashi Iwai
2006-06-05 23:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-06 1:44 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 1:54 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 2:03 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:19 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:35 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 13:30 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 19:40 ` [PATCH] fix missing hdlc symbols for synclink drivers Paul Fulghum
2006-06-06 20:27 ` Krzysztof Halasa
2006-06-06 20:35 ` Paul Fulghum
2006-06-06 21:09 ` Krzysztof Halasa
2006-06-06 21:20 ` Randy.Dunlap
2006-06-06 21:31 ` Krzysztof Halasa
2006-06-06 21:43 ` Paul Fulghum
2006-06-06 20:45 ` Randy.Dunlap
2006-06-06 20:48 ` Randy.Dunlap
2006-06-06 21:08 ` Randy.Dunlap
2006-06-06 22:44 ` Krzysztof Halasa
2006-06-06 22:52 ` Paul Fulghum
2006-06-06 23:07 ` Randy.Dunlap
2006-06-06 23:22 ` Paul Fulghum
2006-06-06 23:37 ` Krzysztof Halasa
2006-06-06 23:51 ` Randy.Dunlap
2006-06-06 23:56 ` Paul Fulghum
2006-06-07 0:12 ` Randy.Dunlap
2006-06-07 0:31 ` Paul Fulghum
2006-06-07 1:20 ` Remove patch from 2.6.17-rc5-mm3 Paul Fulghum
2006-06-07 0:42 ` [PATCH] fix missing hdlc symbols for synclink drivers Krzysztof Halasa
2006-06-07 1:09 ` Paul Fulghum [this message]
2006-06-06 23:11 ` Randy.Dunlap
2006-06-06 21:11 ` Krzysztof Halasa
2006-06-06 21:25 ` Randy.Dunlap
2006-06-06 8:03 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-06 8:09 ` [patch, -rc5-mm3] lock validator: add local_irq_enable_in_hardirq() to ide-floppy.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149642545.2633.49.camel@localhost.localdomain \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox