From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.17-rc6-rt3
Date: Sun, 11 Jun 2006 17:22:06 +0000 [thread overview]
Message-ID: <1150046526.9122.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1150029517.17158.38.camel@Homer.TheSimpsons.net>
On Sun, 2006-06-11 at 14:38 +0200, Mike Galbraith wrote:
> OK, it's dying on the very first call, with absolutely nothing between
> spin_lock_irq() and BUG_ON(!irqs_disabled()), but the spin_lock_irq()
> has become rt_lock(). Is the BUG_ON() check bogus for the rt kernel?
Yes. The patch below should help.
tglx
Index: linux-2.6.17-rc6/kernel/posix-cpu-timers.c
===================================================================
--- linux-2.6.17-rc6.orig/kernel/posix-cpu-timers.c 2006-06-10 09:45:45.000000000 +0200
+++ linux-2.6.17-rc6/kernel/posix-cpu-timers.c 2006-06-10 14:47:10.000000000 +0200
@@ -564,7 +564,7 @@
p->cpu_timers : p->signal->cpu_timers);
head += CPUCLOCK_WHICH(timer->it_clock);
- BUG_ON(!irqs_disabled());
+ BUG_ON_NONRT(!irqs_disabled());
spin_lock(&p->sighand->siglock);
listpos = head;
@@ -721,7 +721,7 @@
/*
* Disarm any old timer after extracting its expiry time.
*/
- BUG_ON(!irqs_disabled());
+ BUG_ON_NONRT(!irqs_disabled());
ret = 0;
spin_lock(&p->sighand->siglock);
next prev parent reply other threads:[~2006-06-11 15:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-10 8:24 2.6.17-rc6-rt3 Ingo Molnar
2006-06-10 10:32 ` 2.6.17-rc6-rt3 Michal Piotrowski
2006-06-10 12:44 ` 2.6.17-rc6-rt3 Thomas Gleixner
2006-06-10 13:30 ` 2.6.17-rc6-rt3 Michal Piotrowski
2006-06-10 14:43 ` 2.6.17-rc6-rt3 Michal Piotrowski
2006-06-10 12:32 ` 2.6.17-rc6-rt3 Mike Galbraith
2006-06-11 12:38 ` 2.6.17-rc6-rt3 Mike Galbraith
2006-06-11 17:22 ` Thomas Gleixner [this message]
2006-06-11 19:26 ` 2.6.17-rc6-rt3 Mark Knecht
2006-06-12 9:20 ` 2.6.17-rc6-rt3 Sébastien Dugué
2006-06-12 9:20 ` 2.6.17-rc6-rt3 Ingo Molnar
2006-06-12 9:35 ` 2.6.17-rc6-rt3 Sébastien Dugué
2006-06-12 9:21 ` 2.6.17-rc6-rt3 Thomas Gleixner
2006-06-12 17:08 ` 2.6.17-rc6-rt3 K.R. Foley
2006-06-12 17:19 ` 2.6.17-rc6-rt3 K.R. Foley
2006-06-12 17:22 ` 2.6.17-rc6-rt3 Thomas Gleixner
2006-06-12 17:32 ` 2.6.17-rc6-rt3 K.R. Foley
2006-06-16 18:51 ` 2.6.17-rc6-rt3 Bruce Eleniak
2006-06-16 19:04 ` 2.6.17-rc6-rt3 Bruce Eleniak
2006-06-16 19:24 ` 2.6.17-rc6-rt3 K.R. Foley
-- strict thread matches above, loose matches on Subject: below --
2006-06-10 13:44 2.6.17-rc6-rt3 henry kay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150046526.9122.1.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox