* [Patch] Cyclades Cleanup
@ 2006-06-11 21:14 Eric Sesterhenn
2006-06-12 9:56 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sesterhenn @ 2006-06-11 21:14 UTC (permalink / raw)
To: linux-kernel; +Cc: async
hi,
coverity choked at two !tty checks, in places where tty can
never be NULL. Since it removes some code we should remove
these checks. (Coverity ids #763,#762)
Signed-off-by Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc5/drivers/char/cyclades.c.orig 2006-06-11 23:11:35.000000000 +0200
+++ linux-2.6.17-rc5/drivers/char/cyclades.c 2006-06-11 23:11:55.000000000 +0200
@@ -2833,7 +2833,7 @@ cy_write(struct tty_struct * tty, const
return 0;
}
- if (!tty || !info->xmit_buf || !tmp_buf){
+ if (!info->xmit_buf || !tmp_buf){
return 0;
}
@@ -2884,7 +2884,7 @@ cy_put_char(struct tty_struct *tty, unsi
if (serial_paranoia_check(info, tty->name, "cy_put_char"))
return;
- if (!tty || !info->xmit_buf)
+ if (!info->xmit_buf)
return;
CY_LOCK(info, flags);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch] Cyclades Cleanup
2006-06-11 21:14 [Patch] Cyclades Cleanup Eric Sesterhenn
@ 2006-06-12 9:56 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-06-12 9:56 UTC (permalink / raw)
To: linux-kernel
Ar Sul, 2006-06-11 am 23:14 +0200, ysgrifennodd Eric Sesterhenn:
> hi,
>
> coverity choked at two !tty checks, in places where tty can
> never be NULL. Since it removes some code we should remove
> these checks. (Coverity ids #763,#762)
>
> Signed-off-by Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-12 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-11 21:14 [Patch] Cyclades Cleanup Eric Sesterhenn
2006-06-12 9:56 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox