* [Patch] Cleanup char/esp.c
@ 2006-06-11 21:24 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-06-11 21:24 UTC (permalink / raw)
To: linux-kernel
hi,
hi,
coverity choked at another two !tty checks, in places where tty can
never be NULL. Since it removes some code we should remove
these checks. (Coverity ids #763,#762)
Signed-off-by Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc5/drivers/char/esp.c.orig 2006-06-11 23:21:37.000000000 +0200
+++ linux-2.6.17-rc5/drivers/char/esp.c 2006-06-11 23:21:55.000000000 +0200
@@ -1212,7 +1212,7 @@ static void rs_put_char(struct tty_struc
if (serial_paranoia_check(info, tty->name, "rs_put_char"))
return;
- if (!tty || !info->xmit_buf)
+ if (!info->xmit_buf)
return;
spin_lock_irqsave(&info->lock, flags);
@@ -1256,7 +1256,7 @@ static int rs_write(struct tty_struct *
if (serial_paranoia_check(info, tty->name, "rs_write"))
return 0;
- if (!tty || !info->xmit_buf)
+ if (!info->xmit_buf)
return 0;
while (1) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-11 21:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-11 21:24 [Patch] Cleanup char/esp.c Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox