Re: [PATCH v2 3/7] platform/x86: uniwill-laptop: Fix behavior of "force" module param

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

On Fri, 17 Apr 2026, Armin Wolf wrote:

> Users might want to force-enable all possible features even on
> machines with a valid device descriptor. Until now the "force"
> module param was ignored on such machines. Fix this to make
> it easier to test for support of new features.
> 
> Fixes: d050479693bb ("platform/x86: Add Uniwill laptop driver")
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  drivers/platform/x86/uniwill/uniwill-acpi.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
> index 5551f193c2c1..7c7ea0e76966 100644
> --- a/drivers/platform/x86/uniwill/uniwill-acpi.c
> +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
> @@ -2481,8 +2481,6 @@ static int __init uniwill_init(void)
>  		if (!force)
>  			return -ENODEV;
>  
> -		/* Assume that the device supports all features */
> -		device_descriptor.features = UINT_MAX;
>  		pr_warn("Loading on a potentially unsupported device\n");
>  	} else {
>  		/*
> @@ -2500,6 +2498,12 @@ static int __init uniwill_init(void)
>  		device_descriptor = *descriptor;
>  	}
>  
> +	if (force) {
> +		/* Assume that the device supports all features */
> +		device_descriptor.features = UINT_MAX;
> +		pr_warn("Enabling potentially unsupported features\n");
> +	}
> +
>  	ret = platform_driver_register(&uniwill_driver);
>  	if (ret < 0)
>  		return ret;
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.