Re: [PATCH 03/16] 64bit resource: fix up printks for resources in networks drivers

Jesse Brandeburg
2006-06-13T16:25:00Z

First, added netdev,

On 6/12/06, Greg KH <greg@kroah.com> wrote:
> From: Greg Kroah-Hartman <gregkh@suse.de>
>
> This is needed if we wish to change the size of the resource structures.
>
> Based on an original patch from Vivek Goyal <vgoyal@in.ibm.com>
>
> Cc: Vivek Goyal <vgoyal@in.ibm.com>
> Cc: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> drivers/net/3c59x.c | 6 ++++--
> drivers/net/8139cp.c | 9 +++++----
> drivers/net/8139too.c | 6 +++---
> drivers/net/e100.c | 4 ++--
> drivers/net/skge.c | 4 ++--
> drivers/net/sky2.c | 6 +++---
> drivers/net/tulip/de2104x.c | 9 +++++----
> drivers/net/tulip/tulip_core.c | 6 +++---
> drivers/net/typhoon.c | 5 +++--
> drivers/net/wan/dscc4.c | 12 ++++++------
> drivers/net/wan/pc300_drv.c | 4 ++--
> 11 files changed, 38 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 31ac001..0c0bd67 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -2678,9 +2678,9 @@ #endif
> goto err_out_free;
> }
>
> - DPRINTK(PROBE, INFO, "addr 0x%lx, irq %d, "
> + DPRINTK(PROBE, INFO, "addr 0x%llx, irq %d, "
> "MAC addr %02X:%02X:%02X:%02X:%02X:%02X\n",
> - pci_resource_start(pdev, 0), pdev->irq,
> + (unsigned long long)pci_resource_start(pdev, 0), pdev->irq,
> netdev->dev_addr[0], netdev->dev_addr[1], netdev->dev_addr[2],
> netdev->dev_addr[3], netdev->dev_addr[4], netdev->dev_addr[5]);

color me confused, but why is this change necessary for e100? e100
can not support 64 bit BARs, so it seems to me to make little sense to
cast to unsigned long long. e100 is 32 bit the whole way through.

Jesse