public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Replace kmalloc and memset in get_undo_list with kzalloc
@ 2006-06-13  2:31 Matt Helsley
  0 siblings, 0 replies; only message in thread
From: Matt Helsley @ 2006-06-13  2:31 UTC (permalink / raw)
  To: trivial; +Cc: LKML, Jes Sorensen

This patch simplifies get_undo_list() by dropping the unnecessary cast,
removing the size variable, and switching to kzalloc() instead of a
kmalloc() followed by a memset().

This cleanup was split then modified from Jes Sorenson's Task Notifiers
patches.

Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
Cc: Jes Sorensen <jes@sgi.com>
--

Compiles, boots.

 ipc/sem.c |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

Index: linux-2.6.17-rc6/ipc/sem.c
===================================================================
--- linux-2.6.17-rc6.orig/ipc/sem.c
+++ linux-2.6.17-rc6/ipc/sem.c
@@ -1002,19 +1002,16 @@ static inline void unlock_semundo(void)
  * This can block, so callers must hold no locks.
  */
 static inline int get_undo_list(struct sem_undo_list **undo_listp)
 {
 	struct sem_undo_list *undo_list;
-	int size;
 
 	undo_list = current->sysvsem.undo_list;
 	if (!undo_list) {
-		size = sizeof(struct sem_undo_list);
-		undo_list = (struct sem_undo_list *) kmalloc(size, GFP_KERNEL);
+		undo_list = kzalloc(sizeof(*undo_list), GFP_KERNEL);
 		if (undo_list == NULL)
 			return -ENOMEM;
-		memset(undo_list, 0, size);
 		spin_lock_init(&undo_list->lock);
 		atomic_set(&undo_list->refcnt, 1);
 		current->sysvsem.undo_list = undo_list;
 	}
 	*undo_listp = undo_list;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-06-13  2:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-13  2:31 Replace kmalloc and memset in get_undo_list with kzalloc Matt Helsley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox