From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org
Subject: PATCH: Fix 32bitism in SDHCI
Date: Thu, 15 Jun 2006 16:33:25 +0100 [thread overview]
Message-ID: <1150385605.3490.85.camel@localhost.localdomain> (raw)
The data field is ulong, pointers fit in ulongs. Casting them to int is
bad for 64bit systems.
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.17-rc6/drivers/mmc/sdhci.c linux-2.6.17-rc6/drivers/mmc/sdhci.c
--- linux.vanilla-2.6.17-rc6/drivers/mmc/sdhci.c 2006-06-06 14:01:11.000000000 +0100
+++ linux-2.6.17-rc6/drivers/mmc/sdhci.c 2006-06-15 11:59:57.580510280 +0100
@@ -1073,7 +1073,7 @@
tasklet_init(&host->finish_tasklet,
sdhci_tasklet_finish, (unsigned long)host);
- setup_timer(&host->timer, sdhci_timeout_timer, (int)host);
+ setup_timer(&host->timer, sdhci_timeout_timer, (unsigned long)host);
ret = request_irq(host->irq, sdhci_irq, SA_SHIRQ,
host->slot_descr, host);
next reply other threads:[~2006-06-15 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 15:33 Alan Cox [this message]
2006-06-15 16:59 ` [Sdhci-devel] PATCH: Fix 32bitism in SDHCI Pierre Ossman
2006-06-15 17:04 ` Russell King
2006-06-15 17:07 ` Pierre Ossman
2006-06-15 17:37 ` Alan Cox
2006-06-15 18:35 ` Mark Lord
2006-06-15 18:50 ` Pierre Ossman
2006-06-15 21:51 ` Alan Cox
2006-06-15 18:52 ` Russell King
2006-06-15 18:59 ` Daniel Drake
2006-06-15 19:05 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150385605.3490.85.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox