From: Pete Popov <ppopov@embeddedalley.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: i2c-algo-ite and i2c-ite planned for removal
Date: Fri, 16 Jun 2006 00:23:17 +0300 [thread overview]
Message-ID: <1150406598.1193.73.camel@localhost.localdomain> (raw)
In-Reply-To: <20060615225723.012c82be.khali@linux-fr.org>
On Thu, 2006-06-15 at 22:57 +0200, Jean Delvare wrote:
> Hi all,
>
> I noticed today that we have an i2c bus driver named i2c-ite,
> supposedly useful on some MIPS systems which have an ITE8172 chip,
> which doesn't compile. It is based on an i2c algorithm driver named
> i2c-algo-ite, which doesn't compile either, due to some changes made to
> the i2c core which weren't properly reflected there. Going back trough
> the versions, I found that the bus driver was previously named
> i2c-adap-ite, and was introduced in 2.4.10. And I don't think it even
> compiled back then either, as it uses a structure (iic_ite) which isn't
> defined anywhere.
>
> So basically we have two drivers in the kernel tree for 5 years or so,
> which never were usable, and nobody seemed to care.
For historical correctness, this driver was once upon a time usable,
though it was a few years ago. It was written by MV for some ref board
that had the ITE chip and it did work. That ref board is no longer
around so it's probably safe to nuke the driver.
Pete
> It's about time to
> get rid of these 1296 lines of code, don't you think? So, unless someone
> volunteers to take care of these drivers, or otherwise has a very
> strong reason to object, I'm going to delete them from the tree soon.
>
> Thanks,
next prev parent reply other threads:[~2006-06-15 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 20:57 i2c-algo-ite and i2c-ite planned for removal Jean Delvare
2006-06-15 21:23 ` Pete Popov [this message]
2006-06-16 20:29 ` Jean Delvare
2006-06-19 16:45 ` Pete Popov
2006-06-20 10:08 ` Jean Delvare
[not found] ` <110701c694f4$f1412fb0$f301a8c0@procsys>
2006-06-22 11:22 ` Ralf Baechle
2006-06-22 10:59 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2006-06-16 17:10 Shane McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150406598.1193.73.camel@localhost.localdomain \
--to=ppopov@embeddedalley.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox