* [PATCH] fix synclink_gt diagnostics error reporting
@ 2006-06-21 14:33 Paul Fulghum
0 siblings, 0 replies; only message in thread
From: Paul Fulghum @ 2006-06-21 14:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Mailing List
Fix diagnostics error reporting that was being
overwritten by incorrect use of return codes from
individual diagnostic functions.
Signed-off-by: Paul Fulghum <paulkf@microgate.com>
--- a/drivers/char/synclink_gt.c 2006-06-21 09:04:11.000000000 -0500
+++ b/drivers/char/synclink_gt.c 2006-06-21 09:24:51.000000000 -0500
@@ -4671,13 +4671,13 @@ static int loopback_test(struct slgt_inf
static int adapter_test(struct slgt_info *info)
{
DBGINFO(("testing %s\n", info->device_name));
- if ((info->init_error = register_test(info)) < 0) {
+ if (register_test(info) < 0) {
printk("register test failure %s addr=%08X\n",
info->device_name, info->phys_reg_addr);
- } else if ((info->init_error = irq_test(info)) < 0) {
+ } else if (irq_test(info) < 0) {
printk("IRQ test failure %s IRQ=%d\n",
info->device_name, info->irq_level);
- } else if ((info->init_error = loopback_test(info)) < 0) {
+ } else if (loopback_test(info) < 0) {
printk("loopback test failure %s\n", info->device_name);
}
return info->init_error;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-21 14:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-21 14:33 [PATCH] fix synclink_gt diagnostics error reporting Paul Fulghum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox