From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: ds@schleef.org
Subject: [Patch] Ignored return value in drivers/mtd/chips/sharp.c
Date: Wed, 21 Jun 2006 22:07:08 +0200 [thread overview]
Message-ID: <1150920428.24106.1.camel@alice> (raw)
hi,
coverity (id #10) spotted that we never reach the return ret; statement,
since ret never gets assigned a value except the 0 at
initialisation. I assume it was meant to hold the result
of sharp_write_oneword().
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6/drivers/mtd/chips/sharp.c.orig 2006-06-21 22:03:45.000000000 +0200
+++ linux-2.6/drivers/mtd/chips/sharp.c 2006-06-21 22:04:48.000000000 +0200
@@ -342,7 +342,8 @@ static int sharp_write(struct mtd_info *
len--;
j++;
}
- sharp_write_oneword(map, &sharp->chips[chipnum], ofs&~3, tbuf.l);
+ ret = sharp_write_oneword(map, &sharp->chips[chipnum],
+ ofs&~3, tbuf.l);
if(ret<0)
return ret;
(*retlen)+=j;
reply other threads:[~2006-06-21 20:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150920428.24106.1.camel@alice \
--to=snakebyte@gmx.de \
--cc=ds@schleef.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox