From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RFC] kill TTY_DONT_FLIP
Date: Fri, 23 Jun 2006 14:25:37 +0100 [thread overview]
Message-ID: <1151069137.4549.11.camel@localhost.localdomain> (raw)
In-Reply-To: <1151002928.15500.21.camel@amdx2.microgate.com>
Ar Iau, 2006-06-22 am 14:02 -0500, ysgrifennodd Paul Fulghum:
> Kill TTY_DONT_FLIP flag, which is set in n_tty read_chan().
> This flag is only used by the N_TTY line discipline. It was added
> in the 2.1.X development series. Its original purpose seems
> to be protecting the N_TTY read buffer state (tty->read_tail, etc)
> from conflicting access by read_chan (reads from N_TTY read buffer)
> and the flip buffer code (writes to N_TTY read buffer
> via n_tty_receive_buf).
>
> The spin lock tty->read_lock was subsequently added to
> protect the N_TTY read buffer. After reviewing the
> tty code, I see no other state that is protected
> by TTY_DONT_FLIP.
Looks good to me on a first review.
Alan
next prev parent reply other threads:[~2006-06-23 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 19:02 [PATCH][RFC] kill TTY_DONT_FLIP Paul Fulghum
2006-06-23 13:25 ` Alan Cox [this message]
2006-06-23 13:41 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151069137.4549.11.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox