From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net, akpm@osdl.org
Subject: Re: Geode patches for 2.6.17
Date: Fri, 23 Jun 2006 22:19:23 +0100 [thread overview]
Message-ID: <1151097563.4549.90.camel@localhost.localdomain> (raw)
In-Reply-To: <20060623205637.GD13017@cosmic.amd.com>
Ar Gwe, 2006-06-23 am 14:56 -0600, ysgrifennodd Jordan Crouse:
> +config VGA_NOPROBE
> + bool "Don't probe VGA at boot" if EMBEDDED
> + default n
> + help
> + Saying Y here will cause the kernel to not probe VGA at boot time.
> + This will break everything that depends on the probed screen
> + data. Say N here unless you are absolutely sure this is what you
> + want.
GAK given all the ifdefs this causes wouldn't it be easier to just fix
the firmware 8)
> @@ -81,6 +96,7 @@ static void gx_set_mode(struct fb_info *
> writel(((info->var.xres * info->var.bits_per_pixel/8) >> 3) + 2,
> par->dc_regs + DC_LINE_SIZE);
>
> +
> /* Enable graphics and video data and unmask address lines. */
> dcfg |= DC_DCFG_GDEN | DC_DCFG_VDEN | DC_DCFG_A20M | DC_DCFG_A18M;
>
Spurious blank line
Otherwise looks good
prev parent reply other threads:[~2006-06-23 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 17:00 [GIT PATCH] Geode patches for 2.6.17 Jordan Crouse
2006-06-23 18:41 ` Alan Cox
2006-06-23 21:07 ` Jordan Crouse
2006-06-23 20:25 ` [GIT PATCH] " Jeff Garzik
2006-06-23 20:56 ` Jordan Crouse
2006-06-23 21:19 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151097563.4549.90.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox