From: corbet@lwn.net (Jonathan Corbet)
To: Andres Salomon <dilinger@queued.net>
Cc: v4l-dvb-maintainer@linuxtv.org, mchehab@infradead.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
video4linux-list@redhat.com
Subject: Re: [PATCH] cafe_ccic: default to allocating DMA buffers at probe time
Date: Wed, 19 Sep 2007 13:31:57 -0600 [thread overview]
Message-ID: <11514.1190230317@lwn.net> (raw)
In-Reply-To: Your message of "Wed, 19 Sep 2007 01:44:18 EDT." <20070919014418.073543bc.dilinger@queued.net>
Andres Salomon <dilinger@queued.net> wrote:
> This patch makes DMA buffer allocation happen during device probe by
> default, and changes the parameter to 'alloc_bufs_at_read'. The
> camera hardware is there, if the cafe_ccic driver is enabled/loaded it
> should do its best to ensure that the camera is actually usable;
> delaying DMA buffer allocation saves an insignicant amount of memory,
> and causes the driver to be much less useful.
The amount of memory isn't quite "insignificant" (three 640x480x2
buffers), but the OLPC people clearly need things to work this way.
There are, as far as I know, no other systems out there using the CAFE
controller. Making things work by default for the one user (with a fair
number of deployed systems!) makes sense to me. So...
Acked-by: Jonathan Corbet <corbet@lwn.net>
That said, I do prefer the original name for the parameter.
jon
Jonathan Corbet / LWN.net / corbet@lwn.net
next prev parent reply other threads:[~2007-09-19 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 5:44 [PATCH] cafe_ccic: default to allocating DMA buffers at probe time Andres Salomon
2007-09-19 19:31 ` Jonathan Corbet [this message]
2007-09-19 22:34 ` [v4l-dvb-maintainer] " Trent Piepho
2007-09-19 22:43 ` Andres Salomon
2007-09-20 0:08 ` Trent Piepho
2007-09-20 15:16 ` Jonathan Corbet
2007-09-24 15:04 ` Mauro Carvalho Chehab
2007-09-25 6:02 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11514.1190230317@lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox