From: Dave Hansen <haveblue@us.ibm.com>
To: Franck <vagabon.xyz@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, Mel Gorman <mel@skynet.ie>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] bootmem: miscellaneous coding style fixes
Date: Tue, 27 Jun 2006 10:26:25 -0700 [thread overview]
Message-ID: <1151429185.24103.8.camel@localhost.localdomain> (raw)
In-Reply-To: <44A12A91.5030704@innova-card.com>
On Tue, 2006-06-27 at 14:54 +0200, Franck Bui-Huu wrote:
> }
> +
> /*
> * link bdata in order
> */
> static void __init link_bootmem(bootmem_data_t *bdata)
> {
> bootmem_data_t *ent;
> +
> if (list_empty(&bdata_list)) {
I'd discourage you from including too many of these in your patches.
One or two is probably OK. But, there are a bunch of them, and it isn't
clear CodingStyle to have spacing like this either way. I'd drop them.
-- Dave
next prev parent reply other threads:[~2006-06-27 17:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 13:11 [PATCH] Clean up the bootmem allocator Franck Bui-Huu
2006-06-26 17:58 ` Dave Hansen
2006-06-26 18:10 ` Andrew Morton
2006-06-27 8:23 ` Franck Bui-Huu
2006-06-27 12:53 ` [PATCH 0/7] " Franck Bui-Huu
2006-06-27 12:53 ` [PATCH 1/7] bootmem: remove useless __init in header file Franck Bui-Huu
2006-06-27 17:17 ` Dave Hansen
2006-06-27 19:18 ` Franck Bui-Huu
2006-06-27 12:53 ` [PATCH 2/7] bootmem: mark link_bootmem() as part of the __init section Franck Bui-Huu
2006-06-27 17:17 ` Dave Hansen
2006-06-27 19:18 ` Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 3/7] bootmem: remove useless parentheses in bootmem header file Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 4/7] bootmem: limit to 80 columns width Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 5/7] bootmem: remove useless headers inclusions Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 6/7] bootmem: use pfn/page conversion macros Franck Bui-Huu
2006-06-27 19:26 ` Dave Hansen
2006-06-29 7:53 ` Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 7/7] bootmem: miscellaneous coding style fixes Franck Bui-Huu
2006-06-27 17:26 ` Dave Hansen [this message]
2006-06-27 19:22 ` Franck Bui-Huu
2006-06-27 22:35 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2006-07-04 15:31 [PATCH 0/7] Clean up the bootmem allocator (try #2) Franck Bui-Huu
2006-07-04 15:46 ` [PATCH 7/7] bootmem: miscellaneous coding style fixes Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151429185.24103.8.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox