From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: holger@convergence.de
Subject: [Patch] Missing statement in drivers/media/dvb/frontends/cx22700.c
Date: Wed, 28 Jun 2006 01:45:12 +0200 [thread overview]
Message-ID: <1151451913.16996.2.camel@alice> (raw)
hi,
stumbled over this because of coverity (id #492),
seems like we are missing a return statement here and fail
to do proper bounds checking. If this assumption is false
we should at least change the identation to make it clear
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c.orig 2006-06-28 01:40:49.000000000 +0200
+++ linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c 2006-06-28 01:41:04.000000000 +0200
@@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx227
return -EINVAL;
if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+ return -EINVAL;
if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
return -EINVAL;
reply other threads:[~2006-06-27 23:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151451913.16996.2.camel@alice \
--to=snakebyte@gmx.de \
--cc=holger@convergence.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox