* [Patch] Missing statement in drivers/media/dvb/frontends/cx22700.c
@ 2006-06-27 23:45 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-06-27 23:45 UTC (permalink / raw)
To: linux-kernel; +Cc: holger
hi,
stumbled over this because of coverity (id #492),
seems like we are missing a return statement here and fail
to do proper bounds checking. If this assumption is false
we should at least change the identation to make it clear
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c.orig 2006-06-28 01:40:49.000000000 +0200
+++ linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c 2006-06-28 01:41:04.000000000 +0200
@@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx227
return -EINVAL;
if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+ return -EINVAL;
if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
return -EINVAL;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-27 23:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-27 23:45 [Patch] Missing statement in drivers/media/dvb/frontends/cx22700.c Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox