Re: [Patch] jbd commit code deadloop when installing Linux

Zou Nan hai
2006-06-28T09:18:48Z

On Wed, 2006-06-28 at 17:10, Arjan van de Ven wrote:
> On Tue, 2006-06-27 at 23:40 -0700, Andrew Morton wrote:
> > On 28 Jun 2006 12:48:43 +0800
> > Zou Nan hai <nanhai.zou@intel.com> wrote:
> >
> > > We see system hang in ext3 jbd code
> > > when Linux install program anaconda copying
> > > packages.
> > >
> > > That is because anaconda is invoked from linuxrc
> > > in initrd when system_state is still SYSTEM_BOOTING.
> > >
> > > Thus the cond_resched checks in journal_commit_transaction
> > > will always return 1 without actually schedule,
> > > then the system fall into deadloop.
> >
> > That's a bug in cond_resched().
>
> hummm while this fix is needed... something makes me want to think that
> something as complex as an OS installer really shouldn't be running with
> SYSTEM_BOOTING state anymore....
> shouldn't we start considering running the initrd (esp now with klibc)
> as SYSTEM_RUNNING ?

Is there any historical reason that we put system_state of app runs
from initrd into SYSTEM_BOOTING instead of SYSTEM_RUNNING?

Zou Nan hai