* [Patch] Deref in drivers/block/paride/pf.c
@ 2006-06-28 21:33 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-06-28 21:33 UTC (permalink / raw)
To: linux-kernel; +Cc: tim
hi,
another possible dereference detected by
coverity (id #759). pf_probe() might call
pf_identify() which might call get_capacity()
which dereferences pf->disk
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git11/drivers/block/paride/pf.c.orig 2006-06-28 23:30:13.000000000 +0200
+++ linux-2.6.17-git11/drivers/block/paride/pf.c 2006-06-28 23:30:32.000000000 +0200
@@ -707,7 +707,7 @@ static int pf_detect(void)
if (pi_init(pf->pi, 0, conf[D_PRT], conf[D_MOD],
conf[D_UNI], conf[D_PRO], conf[D_DLY],
pf_scratch, PI_PF, verbose, pf->name)) {
- if (!pf_probe(pf) && pf->disk) {
+ if (pf->disk && !pf_probe(pf)) {
pf->present = 1;
k++;
} else
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-28 21:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-28 21:33 [Patch] Deref in drivers/block/paride/pf.c Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox