From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: v9fs-developer@lists.sourceforge.net
Subject: [Patch] Dead code in fs/9p/vfs_inode.c
Date: Thu, 29 Jun 2006 00:52:47 +0200 [thread overview]
Message-ID: <1151535167.28311.1.camel@alice> (raw)
hi,
coverity (id #971) found some dead code. In all error
cases ret is NULL, so we can remove the if statement.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git11/fs/9p/vfs_inode.c.orig 2006-06-29 00:50:53.000000000 +0200
+++ linux-2.6.17-git11/fs/9p/vfs_inode.c 2006-06-29 00:51:11.000000000 +0200
@@ -386,9 +386,6 @@ v9fs_inode_from_fid(struct v9fs_session_
error:
kfree(fcall);
- if (ret)
- iput(ret);
-
return ERR_PTR(err);
}
next reply other threads:[~2006-06-28 22:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 22:52 Eric Sesterhenn [this message]
2006-06-28 22:55 ` [V9fs-developer] [Patch] Dead code in fs/9p/vfs_inode.c Russ Cox
2006-06-28 23:16 ` Eric Sesterhenn / Snakebyte
2006-06-28 23:24 ` Russ Cox
2006-06-28 23:41 ` Eric Sesterhenn / Snakebyte
2006-06-29 3:58 ` David Leimbach
2006-06-29 5:27 ` Pekka Enberg
2006-06-29 11:01 ` Jan Engelhardt
2006-06-29 15:16 ` Latchesar Ionkov
2006-06-30 13:44 ` Jan Engelhardt
2006-06-30 14:12 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151535167.28311.1.camel@alice \
--to=snakebyte@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox