From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbWF2JLG (ORCPT ); Thu, 29 Jun 2006 05:11:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751819AbWF2JLF (ORCPT ); Thu, 29 Jun 2006 05:11:05 -0400 Received: from gate.crashing.org ([63.228.1.57]:39913 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S1751369AbWF2JLE (ORCPT ); Thu, 29 Jun 2006 05:11:04 -0400 Subject: Re: Please pull from 'for_paulus' branch of powerpc From: Benjamin Herrenschmidt To: Kumar Gala Cc: Zhang Wei-r63237 , linuxppc-dev@ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org In-Reply-To: References: <9FCDBA58F226D911B202000BDBAD467306E19B76@zch01exm40.ap.freescale.net> Content-Type: text/plain Date: Thu, 29 Jun 2006 19:10:52 +1000 Message-Id: <1151572252.28229.21.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Even though other 86xx platforms have no these PCI chips, these > > codes will not take effect. > > Its code bloat for systems that dont need it. Well... it depends :) If it's totally unlikely to ever have this chip in those platforms, then yes. But if it's common enough, it's fair to have the quirk in a generic place (provided that Whang is right and the fixup is indeed the same for all 86xx platforms) Ben.