From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964927AbWGETFW (ORCPT ); Wed, 5 Jul 2006 15:05:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964962AbWGETFW (ORCPT ); Wed, 5 Jul 2006 15:05:22 -0400 Received: from coyote.holtmann.net ([217.160.111.169]:24478 "EHLO mail.holtmann.net") by vger.kernel.org with ESMTP id S964927AbWGETFW (ORCPT ); Wed, 5 Jul 2006 15:05:22 -0400 Subject: Re: [PATCH] release_firmware() fixes From: Marcel Holtmann To: Magnus Damm Cc: linux-kernel@vger.kernel.org In-Reply-To: <20060705062033.6692.14131.sendpatchset@cherry.local> References: <20060705062033.6692.14131.sendpatchset@cherry.local> Content-Type: text/plain Date: Wed, 05 Jul 2006 21:05:04 +0200 Message-Id: <1152126304.4260.30.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Magnus, > Use release_firmware() to free requested resources. > > According to Documentation/firmware_class/README the request_firmware() call > should be followed by a release_firmware(). Some drivers do not however free > the firmware previously allocated with request_firmware(). This patch tries to > fix this by making sure that release_firmware() is used as expected. thanks for catching these. I even overlooked one one in my own drivers. > Signed-off-by: Magnus Damm Signed-off-by: Marcel Holtmann Regards Marcel