public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brice Goglin <brice@myri.com>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [patch 3/7] Check root chipset no_msi flag instead of all parent busses flags
Date: Thu, 06 Jul 2006 10:50:06 +1000	[thread overview]
Message-ID: <1152147006.24632.53.camel@localhost.localdomain> (raw)
In-Reply-To: <20060703004055.835863000@myri.com>

On Sun, 2006-07-02 at 20:40 -0400, Brice Goglin wrote:
> plain text document attachment
> (03-use_root_chipset_dev_no_msi_instead_of_pci_bus_flags.patch)
> MSI only requires support in the root chipset, which may not even have
> a subordinate bus.
> pci_msi_supported() now checks the no_msi flag in the root_chipset pci_dev
> struct instead of the PCI_BUS_FLAGS_NO_MSI flag of all its parent busses.
> The MSI quirk now sets the no_msi flag accordingly.

I think we shall have msi_ops hanging off struct pci_bus.

That way, MSI support can be "installed" off a given bus and can be
handled differently when necessary. On many platforms, the MSI handling
will actually be different from one bus to the next (the Apple G5 comes
to mind with its PCIe off the northbridge on one side and it's HT<->PCIe
tunnels on the other, using different mecanisms for MSIs, but there are
or will be others).

Ben.



  parent reply	other threads:[~2006-07-06  0:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-03  0:39 [patch 0/7] Improve MSI detection v5 Brice Goglin
2006-07-03  0:40 ` [patch 1/7] Merge existing MSI disabling quirks Brice Goglin
2006-07-03  0:40 ` [patch 2/7] Factorize common MSI detection code from pci_enable_msi() and msix() Brice Goglin
2006-07-03  0:40 ` [patch 3/7] Check root chipset no_msi flag instead of all parent busses flags Brice Goglin
2006-07-04  7:06   ` Grant Grundler
2006-07-04 23:12     ` Brice Goglin
2006-07-05  3:48       ` Grant Grundler
2006-07-05  4:38         ` Brice Goglin
2006-07-06 15:39           ` Grant Grundler
2006-07-06 15:46             ` Brice Goglin
2006-07-06  0:50   ` Benjamin Herrenschmidt [this message]
2006-07-03  0:40 ` [patch 4/7] Rename PCI_CAP_ID_HT_IRQCONF into PCI_CAP_ID_HT Brice Goglin
2006-07-03  0:40 ` [patch 5/7] Blacklist PCI-E chipsets depending on Hypertransport MSI capability Brice Goglin
2006-07-03  0:40 ` [patch 6/7] Drop pci_msi_quirk Brice Goglin
2006-07-03  0:40 ` [patch 7/7] Drop pci bus_flags Brice Goglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1152147006.24632.53.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=brice@myri.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox