From: Richard Purdie <rpurdie@rpsys.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>,
Dirk@Opfer-Online.de
Subject: Re: [patch] fix ucb initialization on collie
Date: Fri, 07 Jul 2006 16:35:50 +0100 [thread overview]
Message-ID: <1152286551.5548.105.camel@localhost.localdomain> (raw)
In-Reply-To: <20060707114145.GA5195@elf.ucw.cz>
On Fri, 2006-07-07 at 13:41 +0200, Pavel Machek wrote:
> From: Dirk Opfer <Dirk@Opfer-Online.de>
>
> Fix ucb initialization on collie. Wrong frequency was used and that
> led to things not working quite correctly. (I had to actually disable
> checks in my tree to get it to boot).
>
> @@ -479,7 +481,7 @@ static int ucb1x00_probe(struct mcp *mcp
> mcp_enable(mcp);
> id = mcp_reg_read(mcp, UCB_ID);
>
> - if (id != UCB_ID_1200 && id != UCB_ID_1300) {
> + if (id != UCB_ID_1200 && id != UCB_ID_1300 && id != UCB_ID_TC35143) {
> printk(KERN_WARNING "UCB1x00 ID not found: %04x\n", id);
UCB_ID_TC35143 isn't defined in mainline, otherwise I'd ack this.
Richard
next prev parent reply other threads:[~2006-07-07 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 11:41 [patch] fix ucb initialization on collie Pavel Machek
2006-07-07 15:35 ` Richard Purdie [this message]
2006-10-26 16:37 ` UCB1400 driver problem in pxa270 saravanan_sprt
2006-10-26 17:14 ` Nicolas Pitre
-- strict thread matches above, loose matches on Subject: below --
2006-07-10 19:49 [patch] fix ucb initialization on collie Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152286551.5548.105.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=Dirk@Opfer-Online.de \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox