Re: [Suspend2-devel] Re: uswsusp history lesson

Bojan Smojver
2006-07-10T00:28:32Z

Quoting "Rafael J. Wysocki" <rjw@sisk.pl>:

> The problem is he _can't_ do it on his own if he wants the code merged,
> because for this purpose some people have to review it, and that's not
> only me or Pavel, but also architecture maintainers, memory management
> maintainers, and probably some other people too. Moreover, Nigel needs
> to address the issues raised by the reviewers.

Of course, of course. Nobody is going to merge anything until relevant
maintainers approve. That's not what I proposed.

My point is something else. A few months back Pavel mentioned that
he's thinking of developers more than users when it comes to Suspend2.
In other words, he was concerned with maintenance of the thing. I'm
also guessing nobody likes signing their name on something they have
fundamental design beef with. All valid points, of course.

In order to avoid all this, my proposal introduces Nigel as the
maintainer of Suspend2 code (i.e. *only* the non-shared bits with
swsusp/uswsusp).

Given that Nigel:

- doesn't want to rip out/change neither swsusp nor uswsusp
- wants to share code as much as possible
- wants to fix things to be technically acceptable
- has shown to able to maintain Suspend2 codebase for users
- no swsusp/uswsup coder would have to worry about Suspend2 code
beyond already shared bits they would worry about anyway

I think it would be appropriate to let him do so (once the initial
technical issues are fixed).

The "your design sucks" argument between Pavel and Nigel is not likely
to be resolved by more talk (this thread is quite appropriately called
"history lesson" :-). These two have been at it for months now, with
no resolution in sight. Yours truly also contributed by useless
flaming from time to time ;-) No need for that any more.

However, Pavel is the one in the position of power here (being the
maintainer), so I think he should, in the interest of users, decide to
give Suspend2 a fair chance (after all those technical issues are
addressed, of course), by letting Suspend2 be in the same position as
swsusp or uswsusp - in other words, in the main tree (actually -mm, to
start with, just as Nigel asked). And with my proposal Pavel and other
swsusp/uswsusp coders, yourself included, would not have to spend any
effort past reviewing the initial set of patches.

In the end, it's a win-win.

--
Bojan